fix(analyze): exclude rationale nodes from gap questions#1780
Closed
balloon72 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Merged on v8, authored to you. Confirmed parity: report.py's Knowledge Gaps filter (degree<=1, not file, not concept, file_type != rationale) now matches suggest_questions() exactly, so the two numbers in the same report agree. 49 analyze tests pass. Thanks — clean consistency fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the isolated-node count in suggested questions consistent with the report's Knowledge Gaps section.
Root cause
report.pyexcludesrationalenodes from knowledge gaps because their expected shape is a single edge to the symbol they explain.suggest_questions()applied the other report filters but omitted that exclusion, so the same graph could show two different isolated-node counts.Changes
file_type != "rationale"filter insuggest_questions().This intentionally does not change cohesion scoring or add JSON/TypeScript naming heuristics.
Validation
python -m pytest tests/test_analyze.py tests/test_report.py tests/test_cluster.py -q(74 passed)python -m py_compile graphify/analyze.py tests/test_analyze.pypython -m graphify update .git diff --check origin/v8...HEADThe full local suite was not repeated because Windows Store Python crashed in existing
ProcessPoolExecutorpipeline tests during the earlier full-suite attempt. GitHub CI remains the full-suite check.Addresses the count mismatch in #1768.